Erez Zilber wrote:
In RedHat 4, some OFED kernel modules (including open-iscsi modules)
use symbols that are encapsulated in ib_core (e.g. kfifo). ib_core
may not be unloaded before open-iscsi is unloaded. Therefore, disconnecting
from open-iscsi over iSER sessions is not suffiecient if the user tries to
stop openibd. The user must be prompted to stop open-iscsi before stopping
openibd.

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 ofed_scripts/ofa_kernel.spec |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/ofed_scripts/ofa_kernel.spec b/ofed_scripts/ofa_kernel.spec
index eed2484..01411e7 100755
--- a/ofed_scripts/ofa_kernel.spec
+++ b/ofed_scripts/ofa_kernel.spec
@@ -455,6 +455,13 @@ if [ -f /etc/SuSE-release ]; then
         fi
 fi
+# If it's RH4, open-iscsi must be stopped before openibd
+if [[ -f /etc/redhat-release && $(grep -c "Red Hat Enterprise Linux AS release 
4" /etc/redhat-release) -eq 1 ]]; then
+    cat /etc/init.d/openibd | sed -e 's/Please logout from all open-iscsi over 
iSER sessions/Please stop open-iscsi: \/etc\/init.d\/iscsi stop/' > 
/etc/init.d/openibd.$$
+    mv /etc/init.d/openibd.$$ /etc/init.d/openibd
+    chmod +x /etc/init.d/openibd
+fi
+
 %if %{build_kernel_ib}
     echo >> %{IB_CONF_DIR}/openib.conf
     echo "# Load UCM module" >> %{IB_CONF_DIR}/openib.conf

Erez,
I changed your patch with the patch below:
See, if this is OK.

From b0409a7d6a1e8f2cfc1de69994420622c6d70b50 Mon Sep 17 00:00:00 2001
From: Vladimir Sokolovsky <[EMAIL PROTECTED]>
Date: Mon, 21 Apr 2008 11:59:14 +0300
Subject: [PATCH] In RedHat 4, some OFED kernel modules (including open-iscsi 
modules)
use symbols that are encapsulated in ib_core (e.g. kfifo). ib_core
may not be unloaded before open-iscsi is unloaded. Therefore, disconnecting
from open-iscsi over iSER sessions is not suffiecient if the user tries to
stop openibd. The user must be prompted to stop open-iscsi before stopping
openibd.

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
Signed-off-by: Vladimir Sokolovsky <[EMAIL PROTECTED]>
---
 ofed_scripts/openibd |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/ofed_scripts/openibd b/ofed_scripts/openibd
index 0e1325d..8272def 100755
--- a/ofed_scripts/openibd
+++ b/ofed_scripts/openibd
@@ -1196,7 +1196,12 @@ stop()

                 if [ $iser_session_cnt -gt 0 ]; then
                         echo
-                        echo "Please logout from all open-iscsi over iSER 
sessions"
+                        # If it's RH4, open-iscsi must be stopped before 
openibd
+                        if [[ -f /etc/redhat-release && $(grep -c "Red Hat 
Enterprise Linux AS release 4" /etc/redhat-release) -eq 1 ]]; then
+                            echo "Please stop open-iscsi: /etc/init.d/iscsi 
stop"
+                        else
+                            echo "Please logout from all open-iscsi over iSER 
sessions"
+                        fi
                         echo "Then run \"$0 $ACTION\""
                         echo
                         exit 1
--
1.5.2.5


_______________________________________________
ewg mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Reply via email to