Does this give the same result? In the data provided, a NEVER matches e

Option Explicit
Sub checksyssystemsas()
Dim r As Long

For r = 2 To Cells(Rows.Count, "a").End(xlUp).Row

If Cells(r, "a") = Cells(r, "e") And Cells(r, "c") = Cells(r, "g") Then
‘msgbox r  ONLY one match at row 1129
Cells(r, "f") = Cells(r, "b")
Cells(r, "h") = Cells(r, "d")
End If

Next r

End Sub

Don Guillett
Microsoft Excel Developer
SalesAid Software
dguille...@gmail.com

From: Siraj Momin (BTG) 
Sent: Sunday, September 16, 2012 8:23 AM
To: Prince Dubey 
Cc: excel-macros@googlegroups.com 
Subject: RE: FW: $$Excel-Macros$$ MATCHING THE VALUE OF COLUMN A AND C WITH 
COLUMN E AND G AND UPDATE THE VALUES.

Hi Prince 

 

Thank you for the reply, I am sending the attachment on your personal email id 
also, I reduced the data but still it taking time I have more data than this to 
update, I am not familiar with array formulas that is the problem

 

Can you help me out in this 

 

Thanks

 

Siraj

 

 

From: Prince Dubey [mailto:prince141...@gmail.com] 
Sent: Sunday, September 16, 2012 3:42 PM
To: excel-macros@googlegroups.com
Cc: Siraj Momin (BTG)
Subject: Re: FW: $$Excel-Macros$$ MATCHING THE VALUE OF COLUMN A AND C WITH 
COLUMN E AND G AND UPDATE THE VALUES.

 

Hi Siraj,

 

As i saw u r using loop on the rang which runs fine on small amount of data but 
in case of large amount of data it will take huge time to process  so do one 
thing instead of looping on the range get all data in an Array then apply same 
logic as u r doing one the range.

 

Or 

 

Please share ur workbook with us.

 

regards

 

Prince

 



On Sunday, September 16, 2012 3:10:57 PM UTC+5:30, Siraj Momin (BTG) wrote:

ANY SOLUTION POSSIBLE

 

SIRAJ

 

 

From: excel-...@googlegroups.com [mailto:excel-...@googlegroups.com] On Behalf 
Of Siraj Momin (BTG)
Sent: Monday, September 10, 2012 5:41 PM
To: excel-...@googlegroups.com
Subject: $$Excel-Macros$$ MATCHING THE VALUE OF COLUMN A AND C WITH COLUMN E 
AND G AND UPDATE THE VALUES.

 

Dear members

 

The following macro I am using to match the values of col A and Col C with Col 
E and Col G and if matched update the value of Col B to Col. F and the value of 
Col D to Col H. Its working fine on small data but on large data its taking 
time can anyone suggest some correction or improvement in this macro.

 

Due to the size limit of the group I did not attached the file.

 

 

Siraj

 

 

Option Explicit

 

Sub checksyssystem1()

Dim r As Long

Dim r1 As Long

Dim c As Long

 

For r = 2 To Cells(Rows.Count, "a").End(xlUp).Row

 

 

For r1 = 2 To Cells(Rows.Count, "g").End(xlUp).Row

If Cells(r, "a") = Cells(r1, "e") And Cells(r, "c") = Cells(r1, "g") Then

Cells(r1, "f") = Cells(r, "b")

Cells(r1, "h") = Cells(r, "d")

If Cells(r, "a") = "" Then

  Exit For

  End If

  

End If

Next r1

Next r

 

End Sub

-- 
Join official facebook page of this forum @ 
https://www.facebook.com/discussexcel
 
FORUM RULES (1120+ members already BANNED for violation)
 
1) Use concise, accurate thread titles. Poor thread titles, like Please Help, 
Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get 
quick attention or may not be answered.
 
2) Don't post a question in the thread of another member.
 
3) Don't post questions regarding breaking or bypassing any security measure.
 
4) Acknowledge the responses you receive, good or bad.
 
5) Cross-promotion of, or links to, forums competitive to this forum in 
signatures are prohibited. 
 
6) Jobs posting is not allowed.
 
7) Sharing copyrighted ebooks/pirated ebooks/their links is not allowed.
 
NOTE : Don't ever post personal or confidential data in a workbook. Forum 
owners and members are not responsible for any loss.
--- 
You received this message because you are subscribed to the Google Groups "MS 
EXCEL AND VBA MACROS" group.
To post to this group, send email to excel-...@googlegroups.com.
To unsubscribe from this group, send email to excel-macros...@googlegroups.com.
 
 

-- 
Join official facebook page of this forum @ 
https://www.facebook.com/discussexcel
 
FORUM RULES (1120+ members already BANNED for violation)
 
1) Use concise, accurate thread titles. Poor thread titles, like Please Help, 
Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get 
quick attention or may not be answered.
 
2) Don't post a question in the thread of another member.
 
3) Don't post questions regarding breaking or bypassing any security measure.
 
4) Acknowledge the responses you receive, good or bad.
 
5) Cross-promotion of, or links to, forums competitive to this forum in 
signatures are prohibited. 
 
6) Jobs posting is not allowed.
 
7) Sharing copyrighted ebooks/pirated ebooks/their links is not allowed.
 
NOTE : Don't ever post personal or confidential data in a workbook. Forum 
owners and members are not responsible for any loss.
--- 
You received this message because you are subscribed to the Google Groups "MS 
EXCEL AND VBA MACROS" group.
To post to this group, send email to excel-macros@googlegroups.com.
To unsubscribe from this group, send email to 
excel-macros+unsubscr...@googlegroups.com.
 
 

-- 
Join official facebook page of this forum @ 
https://www.facebook.com/discussexcel

FORUM RULES (1120+ members already BANNED for violation)

1) Use concise, accurate thread titles. Poor thread titles, like Please Help, 
Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will not get 
quick attention or may not be answered.

2) Don't post a question in the thread of another member.

3) Don't post questions regarding breaking or bypassing any security measure.

4) Acknowledge the responses you receive, good or bad.

5)  Cross-promotion of, or links to, forums competitive to this forum in 
signatures are prohibited. 

6) Jobs posting is not allowed.

7) Sharing copyrighted ebooks/pirated ebooks/their links is not allowed.

NOTE  : Don't ever post personal or confidential data in a workbook. Forum 
owners and members are not responsible for any loss.
--- 
You received this message because you are subscribed to the Google Groups "MS 
EXCEL AND VBA MACROS" group.
To post to this group, send email to excel-macros@googlegroups.com.
To unsubscribe from this group, send email to 
excel-macros+unsubscr...@googlegroups.com.


Reply via email to