Hello,

this mail is caused by my recent frustration with 14 patches for
binutils. Neither one had patch a header, nor at least an "Upstream" line.
Citing from [1]: "In the case of git format-patch-style patches, the
Source: and Reason: lines may be left out if the commit message is
expressive enough and if it is obvious where the patch originated. If
that is not the case, the relevant parts have to be included in the
patch header."

It's IMHO especially annoying because the one adding the patch has
already all the information, just needing to add one small line,  while
the one finding them later has to dig up that information again.

I don't want to suggest any git hooks rejecting patches, so I'll hope
you think of the person dealing with your patches in the future.

Cheers,
Heiko

[1] https://exherbo.org/docs/eapi/exheres-for-smarties.html#applying_patches

_______________________________________________
Exherbo-dev mailing list
[email protected]
http://lists.exherbo.org/mailman/listinfo/exherbo-dev

Reply via email to