https://bugs.exim.org/show_bug.cgi?id=2262

            Bug ID: 2262
           Summary: exim-4.91/src/arc.c:1549: bad if test ?
           Product: Exim
           Version: N/A
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: bug
          Priority: medium
         Component: General execution
          Assignee: ni...@exim.org
          Reporter: dcb...@hotmail.com
                CC: exim-dev@exim.org

[exim-4.91/src/arc.c:1549]: (style) Boolean result is used in bitwise
operation. Clarify expression with parentheses.

Source code is

if (  !*identity | !*selector
   || !(privkey = string_nextinlist(&signspec, &sep, NULL, 0)) || !*privkey)
  {

Maybe better code

if (  !*identity || !*selector
   || !(privkey = string_nextinlist(&signspec, &sep, NULL, 0)) || !*privkey)
  {

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##

Reply via email to