Thanks Oliver and Lorenzo for the advice. I have now made my patch and submitted it, along with a bug report, at https://bugzilla.gnome.org/show_bug.cgi?id=620226
It was very straightforward, the tips to look at Updater.cs for database schema changes made it all very easy. The one part that gave me trouble was making the UI look good. As I said in the bug report, I haven't done GTK before, so I just added a TextView and a label to the "Edit Tag" dialog. This made the TextView ugly with no border or other visual cue, and as the TextView grows and shrinks, the whole dialog grows and shrinks with it. If you want to give me a tip on fixing this, I can, or if it's easy maybe somebody else can just do it themselves. Otherwise I think that the patch is ready to go. I read the discussion in bug 361470. It seems that some people want catalogs in addition to tags, but my preference would be to keep things simple; having one thing in the application, with optional fields that can be ignored (making it more like a tag) or filled out (making it more like a catalog), it seems you get all the benefits of the two objects while keeping both the UI and the code simpler. The description is the only tag enhancement really feels necessary to me. It would be nice (as pointed out in bug 361470) to be able to set the order of photos in a tag/catalog, but that can be done by fiddling with the photo times. It would also be nice if photo exporters used the description when exporting, but there are so many exporters and I didn't want the patch to become too big by adding this feature to each of them. So for now the patch just adds an optional description to each tag, you can fill it out, then you see it when you reopen the "tag description" dialog later. How does it look? _______________________________________________ f-spot-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/f-spot-list
