Hi Sverre. With your change, the output of whatever is executed with `local()` is no longer printed to stdout like it used to.
A patch needs to keep that working to be accepted. That is, working in the same sense of `run` and `sudo` where the output is printed as it is produced - merely printing "output" prior to returning it is not good enough in my opinion. On Thu, Jan 29, 2009 at 7:08 PM, Jeff Forcier <[email protected]> wrote: > Hi Sverre, > > No, I believe I just never got around to adding it to local(), as I > never personally use local() and the "run()/sudo() return command > output" feature was me scratching a specific itch. It's definitely > something good to add for consistency's sake. > > I'll check out your patch, so thanks for that. > > Best, > Jeff > > On Thu, Jan 29, 2009 at 12:48 PM, Sverre Johansen > <[email protected]> wrote: >> Hi, >> >> Is there any reason that local() does not return the output of the >> commands, like run() and sudo() does? >> >> I need this to call `git rev-parse` to use the revision number as part >> of the deploy directory on the server. I also think it makes sense for >> keeping consistency between the functions. >> >> Attached is a patch that implements this. >> >> -- >> Sverre Johansen >> >> _______________________________________________ >> Fab-user mailing list >> [email protected] >> http://lists.nongnu.org/mailman/listinfo/fab-user >> >> > > > _______________________________________________ > Fab-user mailing list > [email protected] > http://lists.nongnu.org/mailman/listinfo/fab-user > -- Venlig hilsen / Kind regards, Christian Vest Hansen. _______________________________________________ Fab-user mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/fab-user
