I'm sorry, I didn't look at everything closely enough. Your version does look cleaner. If you put this in Slava's coding conventions (just with indentation and !!!!!) and make a patch, I could commit this to the core, maybe.
Dan On 7/2/07, Eduardo Cavazos <[EMAIL PROTECTED]> wrote: > On Monday 02 July 2007 11:58, Daniel Ehrenberg wrote: > > > Once curry compiles, combinators will be cleaned up significantly. See > > Slava's post from a little while ago. > > You say that as if I'm not aware. :-) Have you bothered to look at the version > that's "cleaned up significantly"? > > Before I worked on this, I went back to that email to look over the improved > versions. Honestly, I was sort of disappointed. > > Let's take a look at the find from that email : > > : find ( seq quot -- n elt ) > [ find-integer ] (find) ; inline > > : (find) ( seq quot iterator -- n elt ) > pick >r >r (each) r> call r> finish-find ; inline > > : finish-find ( n seq -- n elt ) > over [ dupd nth ] [ drop f ] if ; inline > > : find-integer ( n quot -- ? ) > swap 0 -rot (find-integer) ; inline > > : (find-integer) ( i quot n -- j ) > pick over >= [ > 3drop f > ] [ > >r 2dup 2slip rot [ > r> 2drop > ] [ > >r 1+ r> r> (find-integer) > ] if > ] if ; inline > > Ed > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > Factor-talk mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/factor-talk > ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Factor-talk mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/factor-talk
