Slava Pestov on 2009-05-12 05:47:35 -0500:

> One issue I found, however, is that these two unit tests from
> bloom-filters-tests.factor cause Factor to die with an 'out of memory'
> error on my 64-bit Mac OS X build:

ack!

> [ oversized-filter-params size-bloom-filter ] [ capacity-error? ]
> must-fail-with
> [ oversized-filter-params <bloom-filter> ] [ capacity-error? ] must-fail-with
> 
> I've commented these tests out for now, but I'd like you to fix the
> problem. Could it be related to the fact that the maximum array size
> on 64-bit is very, very large?

I thought I had sized the number big enough to work on a 64-bit machine,
but only tested on a 32-bit one.  I dropped the second test and
increased the relevant size in the first test.  The first test won't
actually create any large arrays (the call to <bit-array> is in
<bloom-filter>), and the second test was just higher up the call chain.
I verified the tests pass (without eating memory) on linux-x86-64 and
linux-x86-32.

  git://github.com/alec/factor.git branch fix-bloom-filters-test

  http://github.com/alec/factor/commit/093faf60e65f39d68d6695a1cdd924002f24622b


------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image 
processing features enabled. http://p.sf.net/sfu/kodak-com
_______________________________________________
Factor-talk mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/factor-talk

Reply via email to