Hi Darrin, Here are some comments.
First of all, instead of constructing an assoc and setting the URL's query slot, you might want to use the set-query-param in the URL's vocab, like so, URL" http://maps.google.com/maps/geo"; clone address "q" set-query-param "csv" "output" set-query-param ... Also note that I clone the URL object below. Right now, the way your code works is that it mutates a shared global constant URL. You need to either clone it, or explicitly construct a URL with <url>: "http://..."; <url> For seq>google-geolocation, you can use input<sequence from the combinators.smart vocab instead of taking the sequence apart manually: [ <google-geolocation> ] input<sequence In this case it doesn't matter, but select-best is O(n log n) when it could be O(n): [ ] [ [ [ accuracy>> ] bi@ before? ] most ] map-reduce Slava On Tue, Jul 21, 2009 at 7:18 AM, Darrin Thompson<[email protected]> wrote: > Slava, > > Yesterday you offered "minor feedback" on this: > > http://paste.factorcode.org/paste?id=790 > > But I was done for the day so I missed it. Care to elaborate? > > -- > Darrin > > ------------------------------------------------------------------------------ > Enter the BlackBerry Developer Challenge > This is your chance to win up to $100,000 in prizes! For a limited time, > vendors submitting new applications to BlackBerry App World(TM) will have > the opportunity to enter the BlackBerry Developer Challenge. See full prize > details at: http://p.sf.net/sfu/Challenge > _______________________________________________ > Factor-talk mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/factor-talk > ------------------------------------------------------------------------------ _______________________________________________ Factor-talk mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/factor-talk
