Hi Keith,
Sorry for the delay in reviewing these changes. I have some feedback
on your code, once you make these changes I will merge them in:
- In the help for with-nested-style, you have a 'top level' string
after the $description. It should be inside a $notes
- You might want to look for other places where with-nested-style
could be used -- try this in the listener:
( scratchpad ) \ with-nesting usage \ with-style usage intersect .
{
with-default-style
$title
P" resource:basis/vocabs/prettyprint/prettyprint.factor"
files.
($see)
($code)
}
- You should clean up the word color logic using predicates and word
props, instead of a bunch of conditionals. That way you won't have to
hard-code USING: USE: and IN:, and instead check for a word property,
ie
GENERIC: word-style ( word -- style )
M: parsing-word word-style ... ;
M: word word-style "style" word-prop ;
- In vocabs.prettyprint, the indentation is a bit funny in one place,
[ [ foo ]
[ bar ] ]
is not idiomatic, instead we would write
[
[ foo ]
[ bar ]
]
Slava
On Thu, Sep 10, 2009 at 7:58 PM, Keith Lazuka <[email protected]> wrote:
> My latest patchset of UI tweaks is ready:
> http://github.com/klazuka/factor/tree/ui
> (the 7 most recent commits)
>
> Nearly all of the changes are purely cosmetic. The only significant
> change that affects downstream is the renaming of 'border-width' in
> the io.styles vocab to "inset". This new "inset" style does the same
> thing, except that it now takes a pair of numbers, one specifying the
> horizontal inset, and the other specifying the vertical inset. This
> allows greater flexibility, plus the name "border-width" was confusing
> as many people would construe it to mean the actual width of the
> border stroke, not an internal margin/padding.
>
> What is the policy for preparing a branch to be merged? I did a phase
> 2 bootstrap, ran relevant unit tests and ran the help-lint tool.
> Should I also rebase my branch against the upstream master? Or should
> I merge in upstream master and then send out the pull request?
>
> -keith
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now. http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Factor-talk mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/factor-talk
>
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Factor-talk mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/factor-talk
