On Fri, Sep 25, 2009 at 4:44 PM, Phil Dawes <[email protected]> wrote: > More vm cleanup: > http://github.com/phildawes/factor/commits/vm_cleanup
Good stuff. Can you also take a look at the indentation of void init_platform_globals() ? Also, I found a regression. This used to throw an 'undefined symbol' error: FUNCTION: void doesnotexist ( ) ; doesnotexist Now it throws a memory protection fault. This is because the relocation code returns a pointer to factor::undefined_symbol(), however you changed this function to take an argument. It's not called with an argument though. Instead, it needs to get the current VM in the same way as signal handlers do, by looking at the VM associated with that thread. > I was going to put all the PRIMITIVE_FORWARD()s in primitives.cpp (and > the PRIMITIVE() declarations in primitives.hpp), but if I do that the > primitive_* member functions in the vm class can't be inline. Do you > think this is a worth doing anyway? Well, you could run the benchmarks before and after and find out :-) "benchmark" run Slava ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Factor-talk mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/factor-talk
