Hi Keith, The code changes look good, except for some stray debug messages in this patch:
http://github.com/klazuka/factor/commit/81ea3afbdc536e9ead1368af8d8a2e5ef7a98a0d Look at 'handle-clear-code' and 'kdebug'. However, I won't merge them until you fix the definition icons; you mention that the conversion to GIF made them look worse. While GIF support is useful in any case, how about using PNG for definition icons instead? Doug pushed some fixes to the PNG code this morning. Slava On Sat, Sep 26, 2009 at 2:33 PM, Keith Lazuka <[email protected]> wrote: > Hi everyone, > > I finished GIF decode support in my "gif" branch > (http://github.com/klazuka/factor/tree/gif). Could someone please > review the code and merge it in if it is acceptable? I'm especially > interested to get feedback regarding code style. I should also note > that no effort at optimization has been made. > > Principal Changes: > - GIFs can now be rendered to the screen (multi frame GIFs are > currently not supported) > - compression.lzw refactored to support both TIFF- and GIF-style LZW > algorithms (there are subtle differences) > - all definition icons were converted from TIFF to GIF. This was > necessary since image in formatted streams are now displayed on > http://docs.factorcode.org. Most browsers do not support TIFF. > - added several unit tests and test images for both images.gif and images.tiff > > Joe, a few of the definition icons did not convert well to GIF. It > seems like there is something weird about the original TIFFs since > when I load the TIFF into Photoshop, it doesn't look correct. Can you > please send me the vector originals so that I can rasterize to GIF? > Thanks. > > I had to redraw the generic word definition icon because the > conversion from the original was so bad. As soon as Joe sends me the > original graphics, I will restore the generic word icon to the > original design. > > -keith > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register now! > http://p.sf.net/sfu/devconf > _______________________________________________ > Factor-talk mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/factor-talk > ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Factor-talk mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/factor-talk
