On Thu, Oct 1, 2009 at 9:35 AM, Phil Dawes <[email protected]> wrote: > Hi Slava, > > Some more patches: > http://github.com/phildawes/factor/tree/reentrantvm
I merged them in. I also found and fixed a stack alignment issue in cpu-x86.32.S, primitive_inline_cache_miss. You were subtracting 16 from the stack pointer, but the return address is already on the stack so that's wrong. I changed it to subtract 12. This fixes the random crash in PIC code on Mac OS X x86/32 that a few people reported. > Just wanted to check something: > > M: ppc %unbox-long-long ( n func -- ) > ! Value must be in r3:r4 > > ..however it looks like only r3 is used. Am I missing a usage (e.g. does > this happen in ppc linux) or is the comment incorrect? It looks like a useless and misleading comment. I removed it. So it appears as if you've cleaned up everything in the VM that I complained about earlier -- nice job. Slava ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Factor-talk mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/factor-talk
