Hi Alexander, On Wed, Sep 7, 2011 at 5:32 PM, Alexander James Vondrak <[email protected]> wrote: >> on Windows and Mac. If we can find a fix for these problems, we can >> release Factor .95 soon. > > Well, that seems like a trivial library to block a release for...
We can't make a release until all libraries load and all tests pass. However there's no rush really. I don't think anyone's critical production infrastructure is blocked on a 0.95 release :-) > Hm. I don't actually know what this is (and don't have access to a Windows > box > to test), but a cursory glance looks like maybe graphviz.ffi is including the > wrong DLL. At least, Graphviz's Graph.cs source loads libgvc-4.dll instead of > gvc.dll. Maybe libgvc-4.dll ships with the binaries and has the functions > we're looking for? This sounds like it could be it. Doug, is the DLL name passed to add-library wrong on Windows? > Yeah, I pondered that one, but didn't get far. How should you test a Graphviz > FFI? I guess create some PNGs/SVGs/whatever by invoking Graphviz manually > (maybe on the examples that come with its source), ship the outputs with the > vocab, then have the unit tests compare those versus the results of using > graphviz.render? As long as the outputs don't differ based on finicky stuff, > like file metadata or anonymous graph names being different or something. > Never mind potential differences between Graphviz versions/installations; > don't > want it to get to the point where we're testing Graphviz itself, rather than > the Factor code. A simple "smoke test" would be fine too; output a PNG and ensure it exists, without checking the contents. This will catch certain types of errors (runtime type errors, memory management mistakes in the FFI, etc). Your use of an FFI call in a parse-time form ($[ ... ]) already ticked a GC bug that I've since fixed :-) Slava ------------------------------------------------------------------------------ Doing More with Less: The Next Generation Virtual Desktop What are the key obstacles that have prevented many mid-market businesses from deploying virtual desktops? How do next-generation virtual desktops provide companies an easier-to-deploy, easier-to-manage and more affordable virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/ _______________________________________________ Factor-talk mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/factor-talk
