On Mon, 12 Dec 2005, Rob Taylor wrote:

You can find the new API branch at
http://projects.collabora.co.uk/darcs/farsight/farsight-new-api

Looks good! Here's a few comments - mostly minor issues:

[farsight-stream.h]
- for specifying network addresses, it's probably best to
  copy from RFC2327 (SDP), and use: 1) address type (IPv4/6),
  2) the actual address (in ascii), 3) transport type (rtp or not,
  if rtp, which profile) and 4) port number -> see defs for c= and m=

- minor documentation issue: for username and password, it might be good
  to refer to IETF ICE specs directly - use of transport specific
  username+password is probably a new thing to most people

- setting the local codec selection might be needed (for example
  to specify which profile/params to use in decoder/depayloading ->
  some of these can be detected from incoming packets, but some
  must be simply agreed out-of-band)

- methods for pausing ('do not send anything', 'do not play out
  received packets' toggles) might be needed in the stream API...
  or should these be protocol/plugin specific?

[farsight-session.h]
- FarsightCodec; should this contain enough info to create
  an SDP offer, or is there some additional interfaces elsewhere?
  .. if not, ability to describe codec params would be needed

--
 under work: Sofia-SIP at http://sofia-sip.sf.net


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Farsight-devel mailing list
Farsight-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/farsight-devel

Reply via email to