Hi, On Tue, 2007-24-04 at 11:23 +0200, SP GLE wrote: > Hi, > here you will find a patch to rtpdtmfsrc, this patch adds ability to > change packet interval and packet redundancy on start and end dtmf > packets.
Thank you for the patches. I've added them to my merge queue[1] and they should be in the next release. I only had to make some minor changes. I believe that in the dtmfsrc patch around line 660 there is a missing else. I reworked that code a bit to make it cleaner. Also, please stay as close as possible to the style of the surrounding code (as ugly as it may be!). That means 80 columns, no trailing whitespace, indentation is 2 spaces (argument continuation 4 spaces). > Even if redundancy works with the dtmf receiver we use i don't think it > is rfc2833 compliant (I think redundant RTP packets on network should > be the same, including timestamp and sequence number, which is not the > case). I believe your patch does the right thing in this case (sending exactly identical packets). Although if they go through the rtpdtmfmuxer, their sequence numbers will be changed, but it should still work properly I believe. Out of curiosity, what are you using farsight for? [1] http://projects.collabora.co.uk/~monkey/gst-plugins-farsight-misc-fixes/ -- Olivier Crête [EMAIL PROTECTED] Collabora Ltd
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
_______________________________________________ Farsight-devel mailing list Farsight-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/farsight-devel
