Hi, I think this patch is wrong, if an event handler returns FALSE, then it means it did not handle the buffer did not take ownership of it, so it does not have to unref it.
The rest of your patches seems good and I've put them in our merge monkey: http://projects.collabora.co.uk/~monkey/gst-plugins-farsight-spgle-fixes/ Thanks for the patches, Olivier On Tue, 2007-05-06 at 14:32 +0200, SP GLE wrote: > Hi, > patch for missing event unref inside rtpjitterbuffer, > regards. > > --- gstrtpjitterbuffer.c.05062007 2007-06-01 10:56:25.000000000 > +0200 > +++ gstrtpjitterbuffer.c 2007-06-05 13:53:21.609421109 +0200 > @@ -681,6 +681,7 @@ newseg_wrong_format: > { > GST_DEBUG_OBJECT (jitterbuffer, "received non TIME newsegment"); > ret = FALSE; > + gst_event_unref (event); > goto done; > } > } > > > > > _____________________________________________________________________________ > Ne gardez plus qu'une seule adresse mail ! Copiez vos mails vers Yahoo! Mail > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > Farsight-devel mailing list > Farsight-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/farsight-devel > -- Olivier Crête [EMAIL PROTECTED] Collabora Ltd
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
_______________________________________________ Farsight-devel mailing list Farsight-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/farsight-devel
