On Thu, 2008-08-21 at 13:04 +0300, Jani Monoses wrote: > Hello, > > I have been reading the existing elements in fs2 and noticed there are > some coding style inconsistencies among them. > > It would help new plugin writers and those trying to understand the code > if there was one preferred way of doing things. They are mostly > equivalent but the slight differences distract the reader especially if > new to fs, gstreamer and gobject programming. > > I attached the patches created by git-format-patch so they have comments > in them.
Thank you, I've applied them as is (except for the second one where I removed one trailing space). > There's another inconsistency in naming the files and identifiers in > them, some are prefixed by gst, others by gst_fs others not at all. You're right, I renamed the gstfs/gst_fs into fs-/fs_ to make it consistent. -- Olivier Crête [EMAIL PROTECTED] Collabora Ltd
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________ Farsight-devel mailing list Farsight-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/farsight-devel
