Thanks, Steven and Divya, I have accepted the patch and also went through the other version of the sorting function to identify similar problems. The updated code has been checked into the SVN repository as revision 805. Please feel free to let us know if you find anything else.
Great detective work. John On 3/4/15 10:23 PM, Enns, Steven wrote: > Hi John, > > I would like to report a bug on behalf of my colleague, Divya > Chandrasekar. She noticed duplicate keys in the results for aggregate > (group by) queries over multiple partitions, and found that adding the > following recursive call to ibis::colStrings::sort resolved the issue. > Please review the suggested fix. Divya can provide more information > if needed at the cc’d address. > > > https://github.com/gingi/fastbit/blob/master/src/colValues.cpp#L3344 > > > for (ibis::colList::iterator ii=head; ii!=tail; ++ii) > (*ii)->swap(i2, i1); > ++ i1; > } > } > if (i1+1 < j) > sort(i1, j, bdl, head, tail); > } > } // end quick sort > #if _DEBUG+0 > 2 || DEBUG+0 > 1 > if (ibis::gVerbose > 5) { > ibis::util::logger lg; > > > > > > _______________________________________________ > FastBit-users mailing list > [email protected] > https://hpcrdm.lbl.gov/cgi-bin/mailman/listinfo/fastbit-users > _______________________________________________ FastBit-users mailing list [email protected] https://hpcrdm.lbl.gov/cgi-bin/mailman/listinfo/fastbit-users
