On Tue, Apr 11, 2006 at 04:44:39AM +0200, Andi Kleen wrote:
> On Mon, Apr 10, 2006 at 06:05:11PM -0400, Vivek Goyal wrote:
> >
> >
> > o Start booting into the capture kernel after an Oops if system is in a
> > unrecoverable state. System will boot into the capture kernel, if one is
> > pre-loaded by the user, and capture the kernel core dump.
> >
> > o One of the following conditions should be true to trigger the booting of
> > capture kernel.
> > - panic_on_oops is set.
> > - pid of current thread is 0
> > - pid of current thread is 1
> > - Oops happened inside interrupt context.
>
> I would rather put it into die(). Then the patch will be much smaller
> too.
Not everybody calls die(), instead they call __die() directly. For example
do_page_fault(), pgtable_bad(). Hence I am putting this call inside __die().
Anyway, if capture kernel is loaded, after displaying the registers and
backtrace, we probably don't want to do anything else and just boot into
capture kernel. Please find attached the modified patch.
o Start booting into the capture kernel after an Oops if system is in a
unrecoverable state. System will boot into the capture kernel, if one is
pre-loaded by the user, and capture the kernel core dump.
o One of the following conditions should be true to trigger the booting of
capture kernel.
- panic_on_oops is set.
- pid of current thread is 0
- pid of current thread is 1
- Oops happened inside interrupt context.
Signed-off-by: Vivek Goyal <[EMAIL PROTECTED]>
---
arch/x86_64/kernel/traps.c | 5 +++++
1 file changed, 5 insertions(+)
diff -puN arch/x86_64/kernel/traps.c~kdump-x86_64-add-crashdump-trigger-points
arch/x86_64/kernel/traps.c
---
linux-2.6.17-rc1-1M/arch/x86_64/kernel/traps.c~kdump-x86_64-add-crashdump-trigger-points
2006-04-11 08:37:08.000000000 -0400
+++ linux-2.6.17-rc1-1M-root/arch/x86_64/kernel/traps.c 2006-04-11
09:03:26.000000000 -0400
@@ -30,6 +30,7 @@
#include <linux/moduleparam.h>
#include <linux/nmi.h>
#include <linux/kprobes.h>
+#include <linux/kexec.h>
#include <asm/system.h>
#include <asm/uaccess.h>
@@ -433,6 +434,8 @@ void __kprobes __die(const char * str, s
printk(KERN_ALERT "RIP ");
printk_address(regs->rip);
printk(" RSP <%016lx>\n", regs->rsp);
+ if (kexec_should_crash(current))
+ crash_kexec(regs);
}
void die(const char * str, struct pt_regs * regs, long err)
@@ -455,6 +458,8 @@ void __kprobes die_nmi(char *str, struct
*/
printk(str, safe_smp_processor_id());
show_registers(regs);
+ if (kexec_should_crash(current))
+ crash_kexec(regs);
if (panic_on_timeout || panic_on_oops)
panic("nmi watchdog");
printk("console shuts up ...\n");
_
_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot
