Vivek Goyal wrote:

On Mon, Jun 26, 2006 at 01:31:28AM -0500, Troy Benjegerdes wrote:
various things like 'reserve_crashkernel' are referenced, but only
exist in arch/powerpc/kernel/machine_kexec_64.c.


I think for ppc32 the framework is present for kexec/kdump but nobody is actively testing/maintaining it as of today.
At present, even though kexec support is included for PPC32, I believe, it has been actively tested/maintained only on gamecube.

Michael, if you are OK with this patch, please send it to upstream.
Thanks
Haren

arch/powerpc/kernel/built-in.o(.init.text+0x1c98): In function `early_init_devtree':
: undefined reference to `reserve_crashkernel'
arch/powerpc/kernel/built-in.o(.init.text+0x1d90): In function `early_init_devtree':
: undefined reference to `overlaps_crashkernel'
This patch will fix the above build errors on ppc32 with CONFIG_KEXEC. Both reserve_crashkernel() and overlaps_crashkernel() should be moved to machine_kexec.c() after the kdump support is included on ppc32.

Signed-off-by: Haren Myneni <[EMAIL PROTECTED]>





Thanks
Vivek
_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot

--- linux-2.6.17-git10/arch/powerpc/kernel/machine_kexec_32.c.orig	2006-06-26 05:33:51.000000000 -0700
+++ linux-2.6.17-git10/arch/powerpc/kernel/machine_kexec_32.c	2006-06-26 05:47:04.000000000 -0700
@@ -63,3 +63,16 @@ int default_machine_kexec_prepare(struct
 {
 	return 0;
 }
+
+/*
+ * FIXME: Move the following functions to machine_kexec.c after
+ * kdump support is included on ppc32.
+ */
+void __init reserve_crashkernel(void)
+{
+}
+
+int overlaps_crashkernel(unsigned long start, unsigned long size)
+{
+	return 0;
+}
_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot

Reply via email to