On Thu, Jul 27, 2006 at 12:32:56PM -0600, Eric W. Biederman wrote:
..
> - Why x86_64 arch_options is non-static.
I guess at the begining x86_64 had support for elf32 core headers and
arch_option was used out side kexec-x86_64.c also. But later this elf32
support was removed but arch_option continued to be extern.
The appended patch should correct it.
Thanks
Maneesh
o x86_64 arch_option is not used anywhere else, so make it "static"
Signed-off-by: Maneesh Soni <[EMAIL PROTECTED]>
---
kexec-tools-1.101-kdump-maneesh/kexec/arch/x86_64/crashdump-x86_64.c | 2 --
kexec-tools-1.101-kdump-maneesh/kexec/arch/x86_64/kexec-x86_64.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff -puN kexec/arch/x86_64/kexec-x86_64.c~x86_64-make-arch_options-static
kexec/arch/x86_64/kexec-x86_64.c
---
kexec-tools-1.101-kdump/kexec/arch/x86_64/kexec-x86_64.c~x86_64-make-arch_options-static
2006-07-28 00:36:00.000000000 +0530
+++ kexec-tools-1.101-kdump-maneesh/kexec/arch/x86_64/kexec-x86_64.c
2006-07-28 00:39:48.000000000 +0530
@@ -139,7 +139,7 @@ void arch_usage(void)
);
}
-struct {
+static struct {
uint8_t reset_vga;
uint16_t serial_base;
uint32_t serial_baud;
diff -puN kexec/arch/x86_64/crashdump-x86_64.c~x86_64-make-arch_options-static
kexec/arch/x86_64/crashdump-x86_64.c
---
kexec-tools-1.101-kdump/kexec/arch/x86_64/crashdump-x86_64.c~x86_64-make-arch_options-static
2006-07-28 00:36:04.000000000 +0530
+++ kexec-tools-1.101-kdump-maneesh/kexec/arch/x86_64/crashdump-x86_64.c
2006-07-28 00:40:02.000000000 +0530
@@ -35,8 +35,6 @@
#include "crashdump-x86_64.h"
#include <x86/x86-linux.h>
-extern struct arch_options_t arch_options;
-
/* Forward Declaration. */
static int exclude_crash_reserve_region(int *nr_ranges);
_
_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot
