Hi again Sam, On Tue, 2006-08-08 at 20:39 +0200, Sam Ravnborg wrote: > On Tue, Aug 08, 2006 at 05:32:11PM +0900, Magnus Damm wrote: > > CONFIG_RELOCATABLE modpost fix > > > > Run modpost on vmlinux regardless of CONFIG_MODULES. > Below is my take on this one. > - Dropped -rR since this is default now > - Dropped subdir- assignment in scripts/Makefile since it is redundant > - Always pass vmlinux ti modpost so we have full updated info > - Print out number of modules being mod posted to distingush from > vmlinux one > - use vmlinux as target name to enable nicer quiet command print
Your patch seems to work as expected if I add a return 0 at the end of modpost.c:secref_whitelist(). I like how you printed out the number of modules being processed. I have one minor comment about your patch: Modpost seems to get run twice on vmlinux if the kernel is built with "make all". I think it would be best to run modpost on vmlinux only when vmlinux is built - never when modules are processed. Thanks, / magnus _______________________________________________ fastboot mailing list [email protected] https://lists.osdl.org/mailman/listinfo/fastboot
