On Mon, Sep 18, 2006 at 03:07:33PM -0400, Vivek Goyal wrote:
> 
> From: Vivek Goyal <[EMAIL PROTECTED]>
> 
> o Sometimes while second kernel is booting, it stomps over the segments
>   stored by kexec/kdump. Of course this is an error condition and should
>   be fixed if such instances are met. Such error conditions are hard to
>   detect sometimes.
> 
> o This patch loads the vmcore elf headers towards the end of the reserved
>   hole instead of loading it towards the beginning of the hole. This
>   effectively keep kernel and elf header segment as far as possible and
>   chances of it getting stomped are less.
> 
> Signed-off-by: Vivek Goyal <[EMAIL PROTECTED]>

Thanks, I have applied this patch to kexec-tools-testing

Signed-off-by: Simon Horman <[EMAIL PROTECTED]>

> ---
> 
>  kexec/arch/x86_64/crashdump-x86_64.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kexec/arch/x86_64/crashdump-x86_64.c 
> b/kexec/arch/x86_64/crashdump-x86_64.c
> index 3c9c0dd..a4225c2 100644
> --- a/kexec/arch/x86_64/crashdump-x86_64.c
> +++ b/kexec/arch/x86_64/crashdump-x86_64.c
> @@ -799,7 +799,7 @@ int load_crashdump_segments(struct kexec
>        * This is a makeshift solution until it is fixed in kernel.
>        */
>       elfcorehdr = add_buffer(info, tmp, sz, 16*1024, align, min_base,
> -                                                     max_addr, 1);
> +                                                     max_addr, -1);
>       if (delete_memmap(memmap_p, elfcorehdr, sz) < 0)
>               return -1;
>       cmdline_add_memmap(mod_cmdline, memmap_p);

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot

Reply via email to