On Thu, Sep 21, 2006 at 09:01:39AM +0800, Zou, Nanhai wrote:
> > -----Original Message-----
> > From: Horms [mailto:[EMAIL PROTECTED]
> > Sent: 2006年9月20日 15:29
> > To: [email protected]
> > Cc: Zou, Nanhai; Eric W. Biederman; Maneesh Soni; Vivek Goyal
> > Subject: [patch 00/11] kexec-tools: ia64 purgatory readability cleanup
> > 
> > Hi,
> > 
> > while examining the code in purgatory/arch/ia64/purgatory-ia64.c
> > I had a lot of trouble following what is going on, even
> > though the code is quite short. The following series of patches
> > aims to make the code somewhat easier to read.
> > 
> > I have tested this code fairly extensively and it seems to be working
> > quite well. I'd like to merge it into kexec-tools-testing. I would
> > be most grateful of some review.
> > 
>   I am ok with all the patches. 
>   Though I think *p1 = *p2 is as readable as memcpy(p1, p2, sizeof(*p1)); and 
> it saves a lot of typing. :)

You have a good point there, I'll drop that patch.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot

Reply via email to