On Thu, Sep 21, 2006 at 05:30:30PM +0900, Horms wrote: > > > > Now I am turning it off. > > > > Its a global for keeping the code changes less. If I make it a parameter > > then I have to change whole lot of functions and code across arches due > > to interdependencies. So for the time being I have kept it a separate > > global. But if you think that it is absolute no-no programming practice, > > then I will write a separate patch to make it a function parameter. > > That is a bit tricky isn't it. Personally I am more in favour of > parameters over globals. But I understand the volume of change issue. > > I think what you have is ok for now. But for interests sake I made > a patch to implement the parameter approach. It is against the updated > patch you sent earlier today. It could be improved by pasing > a general flags parameter, rather than a specific ignore_len_check > parameter. The patch is below. >
Ok. I got rid of global variable and passing the flag as parameter. Also it is a bit wise ORed flag and I am using only 1bit. So in future rest of the 31 bits can be used for other purposes. Posting the patches in a fresh thread. I have done the compilation for i386, x86_64 and ppc64. If somebody can compile it on ia64, would be great as I don't have access to ia64 machine. -Vivek _______________________________________________ fastboot mailing list [email protected] https://lists.osdl.org/mailman/listinfo/fastboot
