Hi!
> >> I don't have a configuration I can test this but it compiles cleanly
> >
> > Ugh, now that's a big patch.. and untested, too :-(.
>
> It was very carefully code reviewed at least the first time,
> and the code was put in sync with code that was tested.
So we had two very different versions of "switch to 64-bit" and now we
have two mostly similar versions. Not a big improvement...
> > Why is PGE no longer required, for example?
>
> PGE is never required. Especially on a temporary page table.
> PGE is an optimization, to make context switches faster.
HPA tells me it is.
> > Can we get it piece-by-piece?
Please?
> >> Vivek has tested this patch for suspend to memory and it works fine.
> >
> > Ok, so it was tested on one config. Given that the patch deals with
> > detecting CPU oddities... :-(
>
> Read the code. Given your scorn and the state of that mess when I
> started I'm not certain a productive conversation can be had.
>
> Do you understand the code as it is currently written?
Mostly. I've written it at some point.
It may be a mess, but patch below is wholesale rewrite, mixing
cleanups (ebx->rbx) with serious changes (PGE). And then you tell me
it was tested on one machine. It is hard/impossible to rewrite, and
changelog is not helpful, either.
Please split it up.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot
