Hi Bob.

2006/12/11 16:16:24 -0500, Bob Montgomery <[EMAIL PROTECTED]> wrote:
>According to /usr/include/zlib.h, for the call to compress2:
>
> Upon entry, destLen is the total size of the
>   destination buffer, which must be at least the value returned by
>   compressBound(sourceLen). 
>[..]
>
>In other words, there is no change in the dumpfile that is created,
>since uncompressible pages are rejected because the result is too large
>instead of because the compress2 call failed with Z_BUF_ERROR.
>
>But the world seems cleaner this way, doesn't it?  I didn't see any
>appreciable speed difference.

Thank you for the comment and the patch.
I think your comment is right, and I have verified that your patch does
not affect the dumpfile both on i386 and ia64. I will include your patch
into the next version of makedumpfile.

Thanks
Ken'ichi Ohmichi
_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot

Reply via email to