On Fri, Jan 05, 2007 at 09:25:51AM +0530, Vivek Goyal wrote: > On Fri, Jan 05, 2007 at 08:20:41AM +0900, Horms wrote: > > > > Taking a step back, when exactly is reset_devices needed? > > Hi Horms, > > Sometimes we encounter a device re-initialization failure in second kernel > because second kernel is booting in special circumstances. (BIOS has been > skipped and underlying device might very well be operational). This command > line option is a hint to the device driver that kernel is booting in a > special environment and reset the underlying device before going ahead > with rest of the initialization. I am not sure how many devices do provide > the capability to reset the devices from software, but this atleast gives > driver a chance to bring the underlying device to a known state and > reducing the chances of initialization failure. > > So far there are no users of this option. But I am hoping down the line > there will be. One possible candidate seems to be cciss driver. That > driver was the trigger point for this command line parameter. > > Hence we need to pass this parameter to second kernel as command line > option. > > This should be an arch independent command line parameter as it deals > with devices. > > This is not an essential parameter. Adding this parameter increases the > chances of success of booting second kernel. Hence looks like hardcoding > it in kexec-tools might not be a very good idea and passing it through init > scripts might make more sense.
Thanks for the clarification. That being the case, I tend to agree with the suggestions of Don and Neil that setting of these kind of command line parameters really would be best done outside of the kexec-tools executable. For now at least. As was suggested, we could start creating a generic script that acts as a guide for distros as well as a starting point for people who using an unpackaged kexec-tools. But I am wary of too much logic ending up in script land. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ _______________________________________________ fastboot mailing list [email protected] https://lists.osdl.org/mailman/listinfo/fastboot
