> Le 27 mars 2018 à 18:13, Oleg Nesterov <o...@redhat.com> a écrit :
>
> On 03/26, Stéphane Letz wrote:
>>
>> If not then I guess this could/should be checked before the FIR generation
>> step and the use of DeclareFunInst.
>
> So you have changed DeclareFunInst::DeclareFunInst() to report the error.
>
> OK, but I think that the error message should include the function name,
> otherwise how the user can understand the problem?
>
> And even if the error message included the function name, how the user can
> know that
>
> process = ffunction(float max_i(), "",""), max(int,int);
>
> is wrong because maxprim.hh does pushFunction("max_i") internally ?
>
>
> -------------------------------------------------------------------------------
> And there is another minor issue... With this patch
>
> process = ffunction(int sinl(float), "","");
>
> always compiles. This code
>
> process = ffunction(int sinl(float), "",""), sin;
>
> fails with the '-quad' option, otherwise it compiles. OK, this is
> understandable
> and probably fine.
>
> -------------------------------------------------------------------------------
> Finally.
>
> process = ffunction(float ANYTHINGBEFOREminANYTHINGAFTER(), "","");
>
> compiles to
>
> output0[i] = FAUSTFLOAT(float(min()));
>
> doesn't look exactly right ;)
>
> Oleg.
>
Some improvements in 2.5.29. Still not perfect, stil some problematic corner
cases. Anyway since « ffunction » is not much of use, it should be OK for now.
Stéphane
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Faudiostream-users mailing list
Faudiostream-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/faudiostream-users
