Changes have been pushed for the repository "fawkes.git".
(Fawkes Robotics Software Framework)

Clone:  g...@git.fawkesrobotics.org:fawkes.git
Gitweb: http://git.fawkesrobotics.org/fawkes.git
Trac:   http://trac.fawkesrobotics.org

The branch, mgomaa/clips-executive-grounding-fix has been created
        at  78be2e85d3259fea480838119906329497138f86 (commit)

http://git.fawkesrobotics.org/fawkes.git/mgomaa/clips-executive-grounding-fix

- *Log* ---------------------------------------------------------------
commit 78be2e85d3259fea480838119906329497138f86
Author:     Mostafa Gomaa <go...@kbsg.rwth-aachen.de>
AuthorDate: Thu Mar 1 00:32:29 2018 +0100
Commit:     Mostafa Gomaa <go...@kbsg.rwth-aachen.de>
CommitDate: Thu Mar 8 12:38:52 2018 +0100

    clips-executive: Fix undesired late Grounding
    
    Fixed case: After actions are already completed and the
        Grounded preconds cleaned, the Grounding is
        triggered again leaving the Grounded precond
        in the factbase.
        This caused the problem that the next time
        this Action is Formulated in a plan. It attempts
        to use the old faulty Grounding.
    
    Reason: After removal of domain-wm-update after the cleaning.
        grounding rules are free to trigger again.

http://git.fawkesrobotics.org/fawkes.git/commit/78be2e8
http://trac.fawkesrobotics.org/changeset/78be2e8

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -


- *Summary* -----------------------------------------------------------


- *Diffs* -------------------------------------------------------------

- *commit* 78be2e85d3259fea480838119906329497138f86 - - - - - - - - - -
Author:  Mostafa Gomaa <go...@kbsg.rwth-aachen.de>
Date:    Thu Mar 1 00:32:29 2018 +0100
Subject: clips-executive: Fix undesired late Grounding

 src/plugins/clips-executive/clips/domain.clp |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

_Diff for modified files_:
diff --git a/src/plugins/clips-executive/clips/domain.clp 
b/src/plugins/clips-executive/clips/domain.clp
index 090e929..734ab56 100644
--- a/src/plugins/clips-executive/clips/domain.clp
+++ b/src/plugins/clips-executive/clips/domain.clp
@@ -203,7 +203,8 @@
   "Ground a non-atomic precondition. Grounding here merely means that we
    duplicate the precondition and tie it to one specific action-id."
   (not (domain-wm-update))
-  (plan-action (action-name ?op) (id ?action-id))
+  (plan-action (action-name ?op) (id ?action-id) 
+    (status FORMULATED|PENDING|WAITING))
   ?precond <- (domain-precondition
                 (name ?precond-name)
                 (part-of ?op)
@@ -251,6 +252,7 @@
   "Ground an atomic precondition of an operator."
   (not (domain-wm-update))
   (plan-action
+    (status FORMULATED|PENDING|WAITING)
     (action-name ?op)
     (param-names $?action-param-names)
     (id ?action-id)




-- 
Fawkes Robotics Framework                 http://www.fawkesrobotics.org
_______________________________________________
fawkes-commits mailing list
fawkes-commits@lists.kbsg.rwth-aachen.de
https://lists.kbsg.rwth-aachen.de/listinfo/fawkes-commits

Reply via email to