#1552: Implement Safari and Opera detection
----------------------------+-----------------------------------------------
  Reporter:  fredck         |       Owner:  th-schwarz        
      Type:  Bug            |      Status:  closed            
  Priority:  High           |   Milestone:  FCKeditor.Java 2.4
 Component:  Server : Java  |     Version:                    
Resolution:  fixed          |    Keywords:                    
----------------------------+-----------------------------------------------
Comment (by fredck):

 The patch is ok fmalikoff. The code seems also to be correct.

 The only thing that I don't like much in that implementation is that the
 retrieveBrowserVersion does the "if (userAgent.indexOf("something")..."
 again, exactly like it was done in the isCompatible. I think this
 repetition could be avoided, even passing the browser name as a parameter
 to retrieveBrowserVersion.

 In any case, I would point all you to the PHP implementation of it, which
 you could use as a base: source:FCKeditor/trunk/fckeditor.php

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/1552#comment:11>
FCKeditor <http://www.fckeditor.net>
The text editor for Internet
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to