#1503: Errors when styles applied to paragraphs as classname
----------------------------+-----------------------------------------------
Reporter: jonhg | Owner: alfonsoml
Type: Bug | Status: new
Priority: Normal | Milestone: FCKeditor 2.6
Component: Core : Styles | Version: FCKeditor 2.5 Beta
Resolution: | Keywords: Review?
----------------------------+-----------------------------------------------
Comment (by fredck):
This fix looks good Alfonso. My only concern is about the change at line
691. Looking at that function isolated, it sounds weird checking it if is
not also true when valueB is null and valueA is !''. Something like this
could fix it (not sure "!valueA && !valueB" would always work):
{{{
return ( valueA == valueB || ( ( valueA === null || valueA === '' ) && (
valueB === null || valueB === '' ) ) )
}}}
If you feel this is correct, go ahead committing it with that change. I
would also ask you to please add the whatsnew entry for it.
--
Ticket URL: <http://dev.fckeditor.net/ticket/1503#comment:7>
FCKeditor <http://www.fckeditor.net>
The text editor for Internet
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
