#35: Use floating panels for dialogs
--------------------------+-------------------------------------------------
Reporter: FredCK | Owner: martinkou
Type: New Feature | Status: assigned
Priority: Normal | Milestone: FCKeditor 2.6
Component: General | Version:
Resolution: | Keywords: Review+
--------------------------+-------------------------------------------------
Changes (by fredck):
* keywords: Review- => Review+
Comment:
I've reviewed all changes with two small changes: [1392] and [1393].
We are ready to go!
For the memory leak, I've made some research (after downloading Martin's
crazy 200MB video), and I've confirmed that removing the Focus() call
removes all memory leak with IE7. I've noted that that call is not needed
at all for IE, so I've changed it with [1393].
For IE6, I still have leaks, and that line makes no changes. It may be
that I'm having those results because I'm using MultipleIEs, not a native
IE6 installation.
Anyway, I believe that the source of the leak is the same as the Focus()
call. It means that the leak is not present in the dialog code, but in the
editor. It is probably related to the fact that the editor receives the
focus, which fires many events in the editor. So probably, the leak
problem is not even present in the Focus() code. Probably only V3 will be
able to fix it.
To conclude, let's move it to trunk!
Martin, I would ask you a lot of attention when merging it to trunk to be
sure other commits applied to trunk are not being reverted. So, the branch
and the trunk must be well aligned. Please check every single changed line
before committing it to trunk, to be sure everything is related to the
dialog needs.
--
Ticket URL: <http://dev.fckeditor.net/ticket/35#comment:65>
FCKeditor <http://www.fckeditor.net>
The text editor for Internet
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
