#1488: new php5 connector
---------------------------+------------------------------------------------
Reporter: tedivm | Owner:
Type: New Feature | Status: closed
Priority: Normal | Milestone: FCKeditor 2.6
Component: Server : PHP | Version:
Resolution: fixed | Keywords: Confirmed HasPatch
---------------------------+------------------------------------------------
Changes (by wwalc):
* status: reopened => closed
* resolution: => fixed
Comment:
Tedvim, I'm very happy that you want to help us, however let me explain
why I've decided not to include all the proposed changes.
Whether things are public or protected does matter, because if someone
used the IsCompatible() method in his application, now it will fail
because of the "protected" keyword.
Customizing the ID field - please create a new ticket for it, explain why
it is so important, so that we could all discuss this new functionality,
instead of simply adding it to the PHP connector. If we all agree that it
is something really needed, we will add this to all connectors, not only
to that specific for PHP5.
Speed/performace - please note that this script has only around 200 lines.
It is not running a million times in a loop. Changing if statements to
ternary statements just because someone wrote they are faster doesn't make
sense. They are faster, but if you run them 1000000 times, you save half a
second. So unless you're in a loop, it's just a matter of coding
preferences. Both ways of string concatenation and writing conditional
statements are valid.
So the key point in changes I applied, was to make it E_STRICT compatible
with older PHP5 versions (<5.1.3) and prepare for PHP6.
--
Ticket URL: <http://dev.fckeditor.net/ticket/1488#comment:6>
FCKeditor <http://www.fckeditor.net>
The text editor for Internet
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
