#1229: <pre> should be merged when applied to multiple paragraphs
----------------------------+-----------------------------------------------
Reporter: Vialis | Owner: martinkou
Type: Bug | Status: reopened
Priority: Normal | Milestone: FCKeditor 2.6.1
Component: Core : Styles | Version: FCKeditor 2.4.3
Resolution: | Keywords: Confirmed Review?
----------------------------+-----------------------------------------------
Comment (by martinkou):
Two flaws in the patch found:
1. The way _CheckAndMergePre() calculates its own previous block instead
of getting the previous block from the FCKDomRangeIterator loop makes it
possible for non-selected <pre> blocks to get merged.
1. While the logic of the _CheckAndSplitPre() in 1229_3.patch looks
identical to the one in 1229_2.patch, it has a very subtle bug - cursor
advancement is incorrectly handled when lastNewBlock exists. The bug
causes _CheckAndSplitPre() to be unable to split a converted block to more
than 2 parts, and also causes it to rearrange the order of the blocks,
which is very bad.
I've included a fixed patch for review.
--
Ticket URL: <http://dev.fckeditor.net/ticket/1229#comment:14>
FCKeditor <http://www.fckeditor.net>
The text editor for Internet
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
