#2218: Improve browser detection
--------------------------+-------------------------------------------------
  Reporter:  wwalc        |       Owner:  martinkou        
      Type:  New Feature  |      Status:  assigned         
  Priority:  Normal       |   Milestone:  FCKeditor 2.6.1  
 Component:  General      |     Version:  SVN              
Resolution:               |    Keywords:  Confirmed Review-
--------------------------+-------------------------------------------------
Changes (by fredck):

  * keywords:  Confirmed Review? => Confirmed Review-

Comment:

 It seems that the code can be much simpler.

  * Line 31 is not anymore needed at this point, as the IsGecko property is
 filled at line 41.

  * It seems the /rv:(\d+\.\d+)/ pattern is a constant for all Gecko based
 browsers. So, we don't need all that version stuff, converting the
 captured match to a float, doing simple numeric comparisons. (some comment
 cleanup is needed at this point).

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/2218#comment:12>
FCKeditor <http://www.fckeditor.net>
The text editor for Internet
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to