#2266: FCKeditor extension for MediaWiki doesn't follow MW's coding conventions
--------------------------+-------------------------------------------------
 Reporter:  Jack Phoenix  |        Type:  Task                         
   Status:  new           |    Priority:  Normal                       
Milestone:                |   Component:  Project : MediaWiki+FCKeditor
  Version:  SVN           |    Keywords:                               
--------------------------+-------------------------------------------------
 FCKeditor extension for MediaWiki doesn't seem to be following MediaWiki's
 coding conventions as described in
 http://www.mediawiki.org/wiki/Manual:Coding_conventions.

 For example, FCKeditorEditPage.body.php had this in two separate lines:

 class FCKeditorEditPage extends EditPage[[BR]]
 {

 when it should've been just one line as per MW's coding conventions:

 class FCKeditorEditPage extends EditPage {

 The extension credits ($wgExtensionCredits) in FCKeditor.php seem to be
 out-of-date and using "double quoting" (i.e. "name" => "FCKeditor", and so
 on) when 'single quoting' would be OK. I've created a patch against the
 current SVN version to fix these minor issues, let's see if I can attach
 it here... ;-)

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/2266>
FCKeditor <http://www.fckeditor.net>
The text editor for Internet
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to