#439: IE: CTRL+Click to open links in a new window
--------------------------+-------------------------------------------------
  Reporter:  Duncan       |       Owner:  martinkou           
      Type:  New Feature  |      Status:  assigned            
  Priority:  Normal       |   Milestone:  FCKeditor 2.6.2     
 Component:  General      |     Version:                      
Resolution:               |    Keywords:  Confirmed IE Review-
--------------------------+-------------------------------------------------
Changes (by fredck):

  * keywords:  Confirmed IE Review? => Confirmed IE Review-

Comment:

 1. The patch assumes that _fcksavedurl will be always available, which is
 not true (paste). The correct way to retrieve the URL should be:

 {{{
 var url = el.getAttribute( '_fcksavedurl' ) || el.getAttribute( 'href' , 2
 ) ;
 }}}

  2. I understand all the RFC stuff, but {{{/:\/\//}}} should be also
 enough to check for a full URL, as well as {{{/^.*:\/\/+[^\/]+/}}} to
 retrieve the "until host" part of the base href.

  3. There is no need to pass {{{'FCKVisitLink'}}} to {{{window.open}}}. It
 would just limit the links to open in the same window, which is not needed
 here.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/439#comment:10>
FCKeditor <http://www.fckeditor.net>
The text editor for Internet
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to