#2234: DIV container tool
--------------------------+-------------------------------------------------
Reporter: fredck | Owner: martinkou
Type: New Feature | Status: assigned
Priority: Normal | Milestone: FCKeditor 2.6.3
Component: General | Version:
Resolution: | Keywords: Confirmed Review-
--------------------------+-------------------------------------------------
Changes (by fredck):
* keywords: Confirmed Review? => Confirmed Review-
Comment:
* Right clicking on the white space at the right side of contained
paragraphs will not display the context menu options for the div.
* The above is also true when clicking the white space between paragraphs
with Show Blocks enabled.
* The tooltip for the toolbar button is "Blockquote". It should be
"Create Div Container".
* I've created following two test styles. No matter which style is used
in the div, style "B" is always selected in the edit dialog.
{{{
<Style name="A" element="div">
<Style name="background-color" value="Yellow" />
<Style name="border" value="1px solid red" />
</Style>
<Style name="B" element="div">
<Style name="border" value="5px solid blue" />
</Style>
}}}
For discussion:
* Let's call it "Div Container", instead of "Div Tag"? A "container" is
more explicit on saying that it will hold other things. A "div tag" can be
used as a container but also as a simple block element, which may cause
some confusion.
* The dialog title should be "Create ...", instead of "Insert ...".
* For cross-blocks selections, I'm a bit unsure about the expected
behavior. Check out [http://pastebin.com/f25d6f011 this pastebin note].
* The toolbar button will not have an on/off state like we have for
blockquote. Being the div creation exclusively done by the dialog box,
couldn't we have the creation code in the dialog file itself instead of
having a command for it? It would help us having the core code a bit
smaller.
Tested it with Firefox 3 on Windows.
--
Ticket URL: <http://dev.fckeditor.net/ticket/2234#comment:6>
FCKeditor <http://www.fckeditor.net>
The text editor for Internet
-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
