#1752: E.tagName has no properties when using tablecommands plugin.
-------------------------+--------------------------------------------------
Reporter: keith.pitt | Owner:
Type: Bug | Status: new
Priority: Normal | Milestone:
Component: General | Version: FCKeditor 2.4
Resolution: | Keywords: Confirmed Review-
-------------------------+--------------------------------------------------
Changes (by fredck):
* keywords: Confirmed Review? => Confirmed Review-
Comment:
The proposed patch fixes the problem, but there a few things to keep
attention:
1. Ok, you are filtering now all ( nodeType == 3 ) nodes... but "if (
oCell.tagName..." is actually looking for ( nodeType == 1 ) stuff. What
about potential nodeType that are not 3 or 1? So, instead of filtering the
buggy part, the more correct and simple approach is simply going right to
the point, by doing "if ( oCell.nodeType == 1 && oCell.tagName...".
2. The patch should also contain the changelog entry for it.
3. A small detail... the coding style should follow our [wiki:CodingStyle
standards].
--
Ticket URL: <http://dev.fckeditor.net/ticket/1752#comment:2>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
