#2514: the code should try to use Array.indexOf if it does exist
-------------------------------+--------------------------------------------
 Reporter:  alfonsoml          |       Owner:              
     Type:  Bug                |      Status:  new         
 Priority:  Normal             |   Milestone:  CKEditor 3.x
Component:  General            |     Version:  SVN         
 Keywords:  Confirmed Review-  |  
-------------------------------+--------------------------------------------
Changes (by fredck):

  * keywords:  Confirmed Review? => Confirmed Review-


Comment:

 1. There is no need to do a typeof check. You can do {{{if( array.indexOf
 )}}}. Less code and better performance (no string comparison).

  2. If we'll be using the browser implementation, we need to make our
 custom implementation work in the same way as the specifications. It means
 that strict equality (===) checks must be used.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/2514#comment:3>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to