#2767: plug-in:basicstyle AND elementpath incorrect style range detection
-------------------------------+--------------------------------------------
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: Core : Styles | Version: SVN
Keywords: Confirmed Review- |
-------------------------------+--------------------------------------------
Changes (by martinkou):
* keywords: Confirmed Review? => Confirmed Review-
Comment:
Actually this has been discuss before (on how to determine the state of
styles - starting point of selection or something else), when we first
implemented the style system back in v2.5. Unfortunately, neither I nor
Fred could find any record of that discussion now.
The basic premise of the patch makes sense - our style system's behavior
should get as close to the usual word processors' as possible (i.e. MS
Word, OpenOffice.org Writer, etc.). However, the style system is known to
be a very delicate piece of code - very easy to get it wrong in some
obscure practical cases. So we'll need quite some test to make sure it's
right.
The getDCAOfNodes() function should be moved to somewhere else or (if
possible), eliminated. The function's name also needs to be more
descriptive. We already have something similar in our current codebase
right now - CKEDITOR.dom.range::getCommonAncestor(). It may not be the
best answer for all cases. But now that we have the CKEDITOR.dom
namespace, this kind of DOM operation should be put inside of that instead
of putting to CKEDITOR.tools. e.g. It may be good to put it as an instance
method for CKEDITOR.dom.node objects.
Review- for the getDCAOfNodes() function. The rest of the patch is good in
general, but needs to be tested rigorously.
--
Ticket URL: <http://dev.fckeditor.net/ticket/2767#comment:7>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
FCKeditor-Trac mailing list
FCKeditor-Trac@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
