#2765: CKEditor is leaving cke_expando indices in the HTML source in IE
---------------------------------+------------------------------------------
Reporter: martinkou | Owner: garry.yao
Type: Bug | Status: reopened
Priority: High | Milestone: CKEditor 3.0
Component: Core : Output Data | Version: SVN
Resolution: | Keywords: Confirmed IE Review-
---------------------------------+------------------------------------------
Changes (by martinkou):
* keywords: Confirmed IE Review? => Confirmed IE Review-
Comment:
Ok... yes in the last review I missed out line 116 in
_source/core/htmlparser/element.js. Thanks for the correction.
_source/plugins/fakeobjects/plugin.js - there's actually a reason for
putting the things like copyParser outside of init(). Function object
construction is a relatively slow operation in JavaScript, so the
frequency of function construction should be minimized - functional
programming techniques, while powerful, should only be used when needed.
Now the reason for putting copyParser(), makeTagOpenerHtml(), etc. outside
of init() is because if we place them outside, those function would be
constructed only once, when the plugin.js file is loaded. If those
functions are placed inside init(), then every init() call would trigger
function construction, which slows down editor instantiation by a bit.
But why are we putting a function on the outside and execute it
immediately? Without the outer function, anything defined in the plugin.js
file (e.g. copyParser) would end up in the global namespace. Even though
we can add them as private variables via _ attributes, many of the things
declared in the plugin.js file are not used anywhere outside of the plugin
itself. So it would make sense to create a local function scope to put
those things in. Thus an outer function is defined to avoid polluting the
global namespace, and avoid adding unnecessary properties under other
global objects.
Not sure about the changes in htmldataprocessor plugin, Fred didn't leave
any documentations about why the plugin is designed like that.
--
Ticket URL: <http://dev.fckeditor.net/ticket/2765#comment:12>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
