#2791: UI flashes when loading.
---------------------------------------+------------------------------------
Reporter: fredck | Owner: garry.yao
Type: Bug | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: General | Version:
Keywords: Confirmed Firefox Review? |
---------------------------------------+------------------------------------
Comment(by martinkou):
I'm in favor of Garry's approach there, !important is something to be
avoided if possible.
Garry's patch, however, obviously wouldn't work - Garry commented out his
own code. :)
Possible concerns with Garry's patch:
1. If I have multiple editor instances within the same page, then I'll
have more than one style tag with the same contents. (e.g.
replacebycode.html sample) That doesn't cause any immediate errors, but
seems wasteful to me.
2. It's more correct to include style tags inside <head>. In v2 we used
to add CSS styles online like this (it's actually split into
fcktools_ie.js and fcktools_gecko.js)...
{{{
if ( document.createStyleSheet )
{
var ss = document.createStyleSheet('');
ss.cssText = cssStyles;
}
else
{
var head = document.getElementsByTagName('head')[0];
var ss = document.createElement('style');
ss.appendChild(document.createTextNode(cssStyles));
head.appendChild(ss);
}
}}}
Fixing point 1 and 2 above would increase the code size a bit though, and
Garry's current approach (with his added line in theme.js uncommented)
doesn't seem to raise any errors or warnings anyway.
--
Ticket URL: <http://dev.fckeditor.net/ticket/2791#comment:5>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
