#2799: V3: The skin file make specific dialog stuff by using the global
CKEDITOR.dialog
-------------------------------+--------------------------------------------
Reporter: fredck | Owner: garry.yao
Type: Bug | Status: assigned
Priority: High | Milestone: CKEditor 3.0
Component: General | Version:
Keywords: Confirmed Review- |
-------------------------------+--------------------------------------------
Changes (by martinkou):
* keywords: Confirmed Review? => Confirmed Review-
Comment:
Review- because the patch doesn't work.
The margin values are there for the mouseMoveHandler()s in the dialog
drag/drop and resize logic. It is used in calculating the bounds for the
dialog's position and sizes, relative to the browser window.
Specifically, the margin values represent areas that logically belong to
the dialog, but visually shouldn't be considered part of the dialog (e.g.
dialog shadows). Those areas should be excluded from calculations of the
dialog's bounding area.
Now, when we look at the patch, the margin values are saved inside the
dialog object, which are under the editor object. That part is correct.
However, the mouseMoveHandler()s in drag/drop and resize part of the code
are still using the margin values from CKEDITOR.dialog._ - which no longer
exists. The net result is the dialog bounding area calculations are wrong
after the patch. e.g. If you drag a dialog around, you'll notice the
bounding area now includes the shadows.
Some other minor problems with the patch:
1. _source/plugins/dialog/plugin.js, line 938: This line shouldn't exist.
2. _source/skins/default/skin.js, line 42, 44, 50: Wrong bracket style.
3. _source/skins/default/skin.js, line 44-110: Wrong indent level (should
be 1 tab instead of 2).
--
Ticket URL: <http://dev.fckeditor.net/ticket/2799#comment:4>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
