#2854: Move table dialog to trunk.
--------------------------+-------------------------------------------------
 Reporter:  martinkou     |       Owner:  martinkou   
     Type:  New Feature   |      Status:  assigned    
 Priority:  Normal        |   Milestone:  CKEditor 3.0
Component:  UI : Dialogs  |     Version:  SVN         
 Keywords:  Review-       |  
--------------------------+-------------------------------------------------
Changes (by fredck):

  * keywords:  Review? => Review-


Comment:

 - As stated on #2792, we must not have the "defaultValues" configuration
 section. Any kind of customization in this sense must be done by using the
 JavaScript API.

  - The dialogs are getting registered twice, one at plugin.js and again at
 table.js. Why is that done in this way?

  - Most of the fields in the dialog are quite simple and their logic could
 be easily separated inside each UI element. There was no need to use the
 setupValue and commitValue artifact for all of them, as it just makes the
 dialog logic hard to follow. The dialog is functional, and we can even
 commit it as is, but this is really bad coding.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/2854#comment:4>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to