#2853: Move image dialog to trunk.
-------------------------------+--------------------------------------------
 Reporter:  martinkou          |       Owner:  arczi       
     Type:  Task               |      Status:  new         
 Priority:  Normal             |   Milestone:  CKEditor 3.0
Component:  UI : Dialogs       |     Version:  SVN         
 Keywords:  Confirmed Review-  |  
-------------------------------+--------------------------------------------
Changes (by fredck):

  * keywords:  Confirmed Review? => Confirmed Review-


Comment:

 - The configurations must not be defined in "levels". They must go all
 directly under CKEDITOR.config. See #2822.

  - The uploadTab and showPreview setting can be avoided, as discussed
 previously. Such customizations can be done by API. I would live the
 browseServer option as this is quite used.

  - The imageDialog variable declaration, other than missing the "var"
 statement, is polluting the global namespace. It must go inside an
 anonymous function declaration.

  - All variables set to functions (like onImgLoadEvent and onSizeChange)
 have no semicolon after the function definition, and some of them is is
 missing the "var" statement.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/2853#comment:6>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to