#2852: Move link dialog to v3 trunk.
-----------------------+----------------------------------------------------
Reporter: martinkou | Owner: martinkou
Type: Task | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: General | Version: SVN
Keywords: Review- |
-----------------------+----------------------------------------------------
Changes (by fredck):
* keywords: Review? => Review-
* component: UI : Dialogs => General
Comment:
- The changes at htmlparser/element.js:
- There is no need to lower case the attribute name. It will always be
lowercased.
- There is no need to trim the replace. It's enough to change the reges
to: ckeClassRegex = /(^|\s+)cke_[^\s]*/g. It also makes the regex more
correct.
- The regex declaration is reusing the multiline "var" statement for
sortAttribs, which is to be avoided. Having several "var"s one after the
other is automatically optimized by the packager.
- The "defaultValues" are to be removed from the configurations. See
#2792. The uploadTab, showAdvancedTab and showTargetTab should also be
removed in favor of the API features.
- The plugin configurations must not go under the CKEDITOR.config.link
object, but directly under CKEDITOR.config. Maybe prefixed with "link_".
See #2822.
- Reusing a single "var" statement for all local functions in the link
dialog make it a big mess. Multiline variable declarations should have its
own "var" statement.
- It's a pity to see all the logic being done inside the onOk function.
That's is not the way to go, but that's the way it will be as we don't
have time to change it now. This dialog is be rewritten later, and
hopefully we'll not have that much people basing their custom plugins on
it.
--
Ticket URL: <http://dev.fckeditor.net/ticket/2852#comment:9>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
