#2916: Implement Flash dialog.
--------------------------+-------------------------------------------------
Reporter: martinkou | Owner: martinkou
Type: Task | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: UI : Dialogs | Version: SVN
Keywords: Review- |
--------------------------+-------------------------------------------------
Changes (by fredck):
* keywords: Review? => Review-
Comment:
Core stuff. I'm a bit stricter here:
* Please rename the "prefix" parameter to "namespace" in
element::getElementsByTag.
* scopeName in IE will always return 'HTML' uppercased. So, the
toLowerCase overhead is unnecessary.
* Let's simplify the code a bit in writeHtml, having the fragment.js code
ignoring any <?xml:namespace> tag.
* Hey Mr. Programmer... please change the "x must be an integer" messages
to "x must be a number" :)
I'll not go that deep on the dialog code. I'll be focused on checking the
dialog usage instead.
* I've pasted
"http://www.adobe.com/devnet/flash/samples/drawing_1/1_coordinates.swf"; in
the URL field. The Preview showed nothing, neither on paste nor when
leaving the field (TAB or click). The <object> tag has been created as
expected though, and the movie can be seen by using the Preview button in
the toolbar.
* When opening a valid flash object, the preview box remains blank.
Actually, it looks like it doesn't work at all, as I was not able to see
that in any case.
Looks good for the rest.
--
Ticket URL: <http://dev.fckeditor.net/ticket/2916#comment:3>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
